fix: Make spire compatible with yargs 14

researchgate · Nov 13, 2019 · 68f7ec8 · 68f7ec8
1 parent c40971d
commit 68f7ec8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/packages/spire/lib/create-cli.js b/packages/spire/lib/create-cli.js
@@ -19,8 +19,13 @@ function createCli() {
       default: false,
       group: 'Options',
     })
-    .exitProcess(false)
-    .strict(true);
+    .command('*', '', () => {}, (argv) => {
+      yargs.showHelp();
+      console.error('\nUnknown command: ' + argv._[0]);
+      process.exit(1);
+    })
+    .demandCommand(1, 'You need to specify at least one command')
+    .exitProcess(false);
 }
 
 module.exports = createCli;
diff --git a/packages/spire/package.json b/packages/spire/package.json
@@ -24,7 +24,7 @@
     "pretty-format": "^24.7.0",
     "signale": "^1.4.0",
     "spire-config-default": "^1.7.3",
-    "yargs": "^14.0.0"
+    "yargs": "^14.2.0"
   },
   "devDependencies": {
     "spire-test-utils": "^1.7.1"

diff --git a/packages/spire/tests/verify.spec.js b/packages/spire/tests/verify.spec.js
@@ -37,7 +37,7 @@ describe('spire', () => {
       }),
     });
     await expect(fixture.run('spire', ['nope'])).rejects.toMatchObject({
-      stderr: expect.stringMatching(/Unknown argument: nope/),
+      stderr: expect.stringMatching(/Unknown command: nope/),
     });
   });
 });