-
Notifications
You must be signed in to change notification settings - Fork 869
fix(web): copy-paste component compatibility issues #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I hate this
it still doesn't work 100% in Gmail's App
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 issues found across 47 files
Prompt for AI agents (all 4 issues)
Understand the root cause of the following 4 issues and fix them.
<file name="apps/web/components/header-and-numbered-list-items/inline-styles.tsx">
<violation number="1" location="apps/web/components/header-and-numbered-list-items/inline-styles.tsx:35">
The new feature title string has a typo (“Vesatile”) and will render incorrect user-facing copy. Please correct it to “Versatile”.</violation>
</file>
<file name="apps/web/components/article-with-single-author/inline-styles.tsx">
<violation number="1" location="apps/web/components/article-with-single-author/inline-styles.tsx:22">
Passing width={undefined} overrides Row’s default width="100%", stripping the width attribute from the rendered table and allowing it to shrink in email clients. Please keep the explicit width.</violation>
</file>
<file name="apps/web/components/header-and-numbered-list-items/tailwind.tsx">
<violation number="1" location="apps/web/components/header-and-numbered-list-items/tailwind.tsx:20">
The first feature title has a typo: it now renders as “Vesatile Comfort” instead of “Versatile Comfort”, introducing a visible copy regression.</violation>
</file>
<file name="apps/web/components/customer-reviews/tailwind.tsx">
<violation number="1" location="apps/web/components/customer-reviews/tailwind.tsx:84">
Wrapping the rating row in <Row>/<Column> puts the <dd> inside the preceding <dt>, so the description list no longer has the required dt/dd sibling structure. That breaks HTML semantics that screen readers rely on and can cause the percentage to be skipped. Please restructure so each <dt> and its <dd> remain siblings.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
apps/web/components/header-and-numbered-list-items/inline-styles.tsx
Outdated
Show resolved
Hide resolved
apps/web/components/header-and-numbered-list-items/tailwind.tsx
Outdated
Show resolved
Hide resolved
|
Isn't passing react-email/packages/row/src/row.tsx Lines 14 to 19 in 149cfdd
|
|
@CarolinaMoraes yeah, those are very intentional, it's so that the Row fits the contents inside itself instead of filling up the space of the parent |
I've tested all of our copy-paste components from https://react.email/components through Litmus on the email clients that we have supported and fixed all of the issues I could find to make them all look good in the email clients.
Some of them still have some very small issues that this doesn't cover, and that probably aren't possible to fix.
This also adds the missing static files from
web/public/statictocomponents/staticso that they're visible inpnpm components:dev.