refactor: reorganize attachments methods to match final API design #717
+107
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
bukinoshita
reviewed
Oct 24, 2025
| } | ||
|
|
||
| export type GetAttachmentResponseSuccess = { | ||
| object: 'attachment'; |
There was a problem hiding this comment.
This need to be changed
Suggested change
| object: 'attachment'; | |
| object: 'email'; |
There was a problem hiding this comment.
Why? Isn't it an attachment? Am I missing something?
There was a problem hiding this comment.
The entity is email, not attachment
There was a problem hiding this comment.
The api does return attachment in this field. So'll just merge as it is, if you mean that we should also change the API let me know and we can talk about this.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
No issues found across 17 files
Linked issue analysis
Linked issue: PRODUCT-791: Rename sdk methods to follow final version
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Moved resend.attachments.sending → resend.emails.attachments | Renamed Sending → Attachments and wired under Emails |
| ✅ | Moved resend.attachments.receiving → resend.emails.receiving.attachments | Created Attachments under receiving and wired into Receiving |
| ✅ | Removed top-level resend.attachments module | Top-level attachments file removed and resend no longer exposes it |
| ✅ | Updated API paths from /emails/sending/ to /emails/ | HTTP paths updated to /emails/${emailId}/attachments in calls |
| ✅ | Replace calls: resend.attachments.sending.* → resend.emails.attachments.* | All sending attachment calls updated to resend.emails.attachments |
| ✅ | Replace calls: resend.attachments.receiving.* → resend.emails.receiving.attachments.* | All receiving attachment calls updated to resend.emails.receiving.attachments |
| ✅ | Stop importing attachments interfaces from the top-level index | Top-level export removed and imports updated to new paths |
| ✅ | Move/rename attachments interfaces under emails/attachments and update imports | Interfaces added/moved under emails/receiving/attachments and adjusted imports |
| ❌ | Depends on resend-api PR #2291 (use /emails/ endpoints) | External API PR referenced but not implemented here |
- Moved resend.attachments.sending → resend.emails.attachments - Moved resend.attachments.receiving → resend.emails.receiving.attachments - Removed top-level resend.attachments module - Updated API paths from /emails/sending/ to /emails/
vieiralucas
force-pushed
the
feature/product-791-rename-sdk-methods-to-follow-final-version
branch
from
b60b625 to
c957e51
Compare
lucasfcosta
approved these changes
Oct 27, 2025
vieiralucas
deleted the
feature/product-791-rename-sdk-methods-to-follow-final-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/resend/resend-api/pull/2291
Summary by cubic
Reorganized attachments under Emails to match the final API design and align with PRODUCT-791. Endpoints now use /emails/, and the top-level attachments module is removed.
Refactors
Migration