Skip to content

fix: remove unsupported types #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

fix: remove unsupported types #726

merged 1 commit into from
Oct 28, 2025
+4 −158

Conversation

@CarolinaMoraes
Copy link
Contributor

@CarolinaMoraes CarolinaMoraes commented Oct 28, 2025 •
edited by cubic-dev-ai bot
Loading

Summary by cubic

Restricted template variable types to string and number only, removing boolean, object, and list support. This aligns interfaces and parsing with the email API to prevent invalid payloads.

  • Bug Fixes

    • Limit variables to Record<string, string | number> in email and template options.
    • Update parseTemplateToApiOptions to handle only string/number fallbacks; removed tests for unsupported types.

  • Migration

    • Replace boolean/object/list variables with string/number values (e.g., "true"/"false", or JSON string).
    • No changes needed if you already use string/number variables.

@CarolinaMoraes CarolinaMoraes self-assigned this Oct 28, 2025
@CarolinaMoraes CarolinaMoraes requested a review from a team as a code owner October 28, 2025 15:01
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 28, 2025

Open in StackBlitz

npm i https://pkg.pr.new/resend/resend-node/resend@726

commit: fdcd0bb

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@CarolinaMoraes CarolinaMoraes merged commit 33ae1ce into canary Oct 28, 2025
14 checks passed
@CarolinaMoraes CarolinaMoraes deleted the preview-templates branch October 28, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@gabrielmfern gabrielmfern gabrielmfern approved these changes

Assignees

@CarolinaMoraes CarolinaMoraes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CarolinaMoraes @gabrielmfern