Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STARK: Implement the diary pages menu #1443

Merged
merged 7 commits into from Jun 15, 2018

Conversation

Projects
None yet
2 participants
@DouglasLiuGamer
Copy link
Collaborator

DouglasLiuGamer commented Jun 10, 2018

This PR is corresponding to implementing the diary pages menu of TLJ.

@DouglasLiuGamer DouglasLiuGamer requested a review from bgK Jun 10, 2018

@DouglasLiuGamer DouglasLiuGamer force-pushed the DouglasLiuGamer:branch-diary branch from 51afd0c to 6f217ba Jun 12, 2018

@DouglasLiuGamer DouglasLiuGamer force-pushed the DouglasLiuGamer:branch-diary branch from 6f217ba to a32fbb1 Jun 13, 2018

@bgK
Copy link
Member

bgK left a comment

Looks pretty good!


_page = StarkDiary->getPageIndex();

_widgets.push_back(new DiaryWidget(_page));

This comment has been minimized.

@bgK

bgK Jun 13, 2018

Member

This crashes in the corner case of old saves that don't have any diary pages.

Resources::Layer *layer = location->getLayerByName(StarkDiary->getDiary(diaryIndex));

// Diary page layer contains only one item, the text
_renderEntry = layer->listRenderEntries()[0];

This comment has been minimized.

@bgK

bgK Jun 13, 2018

Member

Some kind of error handling seems to be missing for when the layer was not found.

@bgK bgK merged commit 78d599e into residualvm:master Jun 15, 2018

1 check passed

default Build finished.
Details

@DouglasLiuGamer DouglasLiuGamer deleted the DouglasLiuGamer:branch-diary branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.