Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRAPHICS: Do not use SDL_WINDOW_RESIZEABLE #1574

Merged
merged 4 commits into from Sep 9, 2019

Conversation

@raziel-
Copy link
Contributor

commented Sep 7, 2019

See also the forums thread for further information
https://forums.residualvm.org/viewtopic.php?f=1&t=766

raziel- added 2 commits Sep 7, 2019

@raziel- raziel- changed the title GRAPHICS: Do not use SDL_WINDOW_RESIZEABLE on AmigaOS4 GRAPHICS: Do not use SDL_WINDOW_RESIZEABLE Sep 9, 2019

@raziel-

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

@bgK

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Please leave SDL_WINDOW_RESIZEABLE, the window is intended to be resizeable.

What needs to be done here is to make the window not resizeable when the game does not support arbitrary resolutions and the platform does not support rendering to a framebuffer.

@raziel-

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

That is beyond my capabilities, sorry

SDL: Disallow resizing the window when support is not available
The window can be resized when the game supports arbitrary resolutions
or the platform allows rendering to a framebuffer.
@bgK

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

I've pushed a change to your branch to implement that rule. Would you mind testing it on AmigaOS ?

@raziel-

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

@bkk

With your change it still works on AmigaOS4.
I get a window missing the resize gadget.

@bgK

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Ok, let's merge it then.

@bgK bgK merged commit 6e02a10 into residualvm:master Sep 9, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.