New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up circleci npm autopublishing #109

Merged
merged 2 commits into from Nov 22, 2017

Conversation

Projects
None yet
2 participants
@pimterry
Collaborator

pimterry commented Nov 21, 2017

Based on the existing config from https://github.com/resin-io-modules/resin-pine.

Change-Type: patch

Set up circleci npm autopublishing
Change-Type: patch

@pimterry pimterry requested a review from MoranF Nov 21, 2017

@MoranF

This comment has been minimized.

Show comment
Hide comment
@MoranF

MoranF Nov 22, 2017

Contributor

@pimterry , I just want to make sure I understand, because I'm not that familiar with Circleci. Do you test it with node-8 and with node-6 but deploy it with node-6?

Contributor

MoranF commented Nov 22, 2017

@pimterry , I just want to make sure I understand, because I'm not that familiar with Circleci. Do you test it with node-8 and with node-6 but deploy it with node-6?

@pimterry

This comment has been minimized.

Show comment
Hide comment
@pimterry

pimterry Nov 22, 2017

Collaborator

@MoranF yes, exactly.

We have to deploy from one, and it shouldn't make any difference in principle, but we deploy node 6 just because it's probably safer if there is a difference (code that works on node 6 is more likely to work on node 8 than the other way around).

Nobody is very familar with CircleCI yet, so no need to worry about that. It is definitely good to spend some time reading through it to get a general idea of what's going on though, because the plan is to move everything on Travis to Circle instead, so the more people who understand it the better!

Collaborator

pimterry commented Nov 22, 2017

@MoranF yes, exactly.

We have to deploy from one, and it shouldn't make any difference in principle, but we deploy node 6 just because it's probably safer if there is a difference (code that works on node 6 is more likely to work on node 8 than the other way around).

Nobody is very familar with CircleCI yet, so no need to worry about that. It is definitely good to spend some time reading through it to get a general idea of what's going on though, because the plan is to move everything on Travis to Circle instead, so the more people who understand it the better!

@MoranF

MoranF approved these changes Nov 22, 2017

I don't have a way to test it but looks good

@pimterry

This comment has been minimized.

Show comment
Hide comment
@pimterry

pimterry Nov 22, 2017

Collaborator

I don't have a way to test it but looks good

Neither do I 😃. It's passing on this PR though, and the deployment part works in resin-pine, so lets hope it works!

Collaborator

pimterry commented Nov 22, 2017

I don't have a way to test it but looks good

Neither do I 😃. It's passing on this PR though, and the deployment part works in resin-pine, so lets hope it works!

@resin-io-modules-versionbot resin-io-modules-versionbot bot merged commit f10ffc4 into master Nov 22, 2017

8 checks passed

AutoMerges PR merging is in progress
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags
ci/circleci: node-6 Your tests passed on CircleCI!
Details
ci/circleci: node-8 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
hound No violations found. Woof!

@resin-io-modules-versionbot resin-io-modules-versionbot bot deleted the autodeploy branch Nov 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment