New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small improvements #32

Merged
merged 3 commits into from Dec 11, 2017

Conversation

Projects
None yet
2 participants
@pimterry
Contributor

pimterry commented Nov 27, 2017

This PR:

  • Updates Bluebird (the current version is very out of date doesn't support things like catchReturn, which some downstream projects assume exist)
  • Adds error handling for the createReadStream call - I'm not actually sure if that was causing issues in my resin-device-init code, but it's certainly a risky operation that previously would silently implode if it fails (and which now properly emits an error instead)
  • Move from using .on() followed by .removeListener to use .once instead, and generally try to make the code a little clearer

pimterry added some commits Nov 27, 2017

Update Bluebird to v3
Change-Type: patch

@pimterry pimterry requested a review from zvin Nov 27, 2017

@zvin

zvin approved these changes Dec 11, 2017

@resin-io-modules-versionbot resin-io-modules-versionbot bot merged commit 7b83269 into master Dec 11, 2017

3 of 6 checks passed

ci/circleci: node-6 Your tests are queued behind your running builds
Details
ci/circleci: node-8 Your tests are queued behind your running builds
Details
hound Hound is busy reviewing changes...
AutoMerges PR merging is in progress
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags

@resin-io-modules-versionbot resin-io-modules-versionbot bot deleted the small-improvements branch Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment