New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test request mocking #46

Merged
merged 4 commits into from Sep 14, 2018

Conversation

Projects
None yet
3 participants
@pimterry
Collaborator

pimterry commented Sep 7, 2018

Connects to #45

This sticks with the existing resin-config-karma version, but moves it to Chrome (required because resin-request now uses dependencies that use const), and changes the Circle base images to ones with Chrome preinstalled to make that work.

pimterry added some commits Sep 7, 2018

Test with Mockttp now that request._setFetch has been removed
Change-type: patch
Signed-off-by: Tim Perry <tim@resin.io>
Run tests in headless Chrome, not PhantomJS
Signed-off-by: Tim Perry <tim@resin.io>

@pimterry pimterry requested a review from Page- Sep 7, 2018

@Page-

Page- approved these changes Sep 7, 2018

thgreasi added some commits Sep 14, 2018

appveyor: Use npm v5 since v6 errors on node v4
Change-type: patch
Signed-off-by: Thodoris Greasidis <thodoris@resin.io>

@pimterry pimterry merged commit eaa0e18 into master Sep 14, 2018

13 of 15 checks passed

ResinCI/npm/linux-alpine-x86_64-node6
Details
ResinCI/npm/linux-alpine-x86_64-node8
Details
Hound No violations found. Woof!
ResinCI/check-commits/commits Commit checks passed
Details
ResinCI/check-files/license license check passed
Details
ResinCI/check-files/readme readme check passed
Details
ResinCI/check-versionist/versionist Automatic versioning can be performed
Details
ResinCI/is-pr/base-branch Pr is against master
Details
ResinCI/npm/linux-alpine-x86_64-node10
Details
ResinCI/npm/store-npm
Details
ResinCI/store-github/store-github Will successfully increase version on master
Details
ci/circleci: node-6 Your tests passed on CircleCI!
Details
ci/circleci: node-8 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@pimterry pimterry deleted the 45-fix-request-mocking branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment