New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow requests to be sent without a token, even if one exists #105

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
2 participants
@pimterry
Collaborator

pimterry commented Oct 4, 2017

This is eventually going to be part of a solution for resin-io/resin-cli#443 - currently the CLI breaks in some place because basic requests for config (which don't even need authentication) fail if you have an invalid token, because we can't avoid sending the token even when we don't need it.

Once this is done, the SDK will stop sending the token with requests that don't need authentication, and the CLI will magically stop breaking (there's actually some other issues too, but it'll get much closer at least!)

@thgreasi

👍

Show outdated Hide outdated lib/request.coffee

@pimterry pimterry merged commit b974125 into master Oct 5, 2017

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
hound No violations found. Woof!

@pimterry pimterry deleted the allow-tokenless-requests branch Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment