New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add owns__device to the application resource, and fix local dev URLs #918

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@pimterry
Member

pimterry commented Oct 9, 2018

This adds an example expanding from application to devices, after a user (https://app.frontapp.com/open/cnv_11nbptv) pointed out that that wasn't documented.

This PR also changes the default API_BASE. Everywhere expects this to not have a trailing slash, and it doesn't appear to in production, but in dev every generated URL ends up with a double slash here before this change.

Fixes #917

pimterry added some commits Oct 9, 2018

Add owns__device to the application resource docs
Change-type: patch
Signed-off-by: Tim Perry <tim@resin.io>
Remove the extra trailing slash in URLs during local dev
Change-type: patch
Signed-off-by: Tim Perry <tim@resin.io>

@pimterry pimterry requested review from thgreasi and dimitrisnl Oct 9, 2018

@wafflebot wafflebot bot added the in progress label Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment