New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pre-gyp releases use the existing versionbot tag (not a new one) #13

Merged
merged 2 commits into from Nov 21, 2017

Conversation

Projects
None yet
2 participants
@pimterry
Member

pimterry commented Nov 21, 2017

The pre-gyp publishing works nicely (see https://github.com/resin-io/node-ext2fs/releases/tag/0.1.0), but causes some mess (multiple builds, with only one of each pair of jobs succeeding) due to a mismatch with versionbot. What happens is:

  • Versionbot pushes a v0.1.0 tag
  • Travis builds it
  • pre-gyp-github publishes the result from each job to a 0.1.0 release on github
  • That release is a new tag, because it has no v prefix.
  • In parallel, travis starts a build for the 0.1.0, and tries to also publish those to github
  • We're now building & publishing for each combination twice, and the 2nd in each pair will fail (because the result has already been published).

This PR makes pre-gyp use a prefixed v0.1.0 release instead, which shouldn't create a new tag, and should avoid this entirely.

@pimterry pimterry requested a review from zvin Nov 21, 2017

@zvin

zvin approved these changes Nov 21, 2017

@resin-io-versionbot resin-io-versionbot bot merged commit 0109dce into master Nov 21, 2017

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
AutoMerges PR merging is in progress
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags

@resin-io-versionbot resin-io-versionbot bot deleted the pre-gyp-v-prefix branch Nov 21, 2017

@pimterry pimterry referenced this pull request Feb 20, 2018

Open

Reconfix integration. #773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment