Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Ensure hostname truly is optional when configuring device images #676
This fixes #600: right now attempting to configure a ResinOS 2.x image includes an optional hostname setting under advanced settings, but if you don't set it reconfix explodes. With this change, it's truly optional: if you don't set it, the image doesn't get anything added.
I've added this in a somewhat hacky way, mainly because it's a painful bug for users in the field that I'd like to sweep through, and we're going to do a proper reconfixication of the CLI soon anyway, so this won't last too long.
I'd be very interested in tidier solutions though, where I can declare hostname as optional in the schema itself. I tried some (fairly complicated) options using