New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start adding TypeScript to the CLI and stop committing build output #720

Merged
merged 6 commits into from Nov 27, 2017

Conversation

Projects
None yet
3 participants
@pimterry
Member

pimterry commented Nov 23, 2017

@dfunckt mentioned that he's going to be adding some CLI features soon, based on TS code elsewhere: https://www.flowdock.com/app/rulemotion/resin-tech/threads/w9ehtABDLGFpdKQ8bJLI2hVXuiA. That means it'd be useful to start the TS migration sooner rather than later, if possible.

This PR does that, largely based on the patterns in the SDK. It:

  • Adds a minimal TS setup
  • Converts a single tiny file, to check it works
  • Stops committing the JS output of the build. It gets regenerated at publish time anyway, and it's just a recipe for conflicts and hassle.
  • Moves from a .npmignore blacklist of files to not publish to a files whitelist in package.json.

pimterry added some commits Nov 23, 2017

Don't commit raw JS build output
This lets us avoid lots of potential conflicts, issues, and confusion,
and keeps reviews simpler and cleaner.

Change-Type: patch
@thgreasi

LGTM but plz add a semicolon in the renamed lib/config.ts.
We should open a tslint + prettier + after this gets merged and do the same to the SDK
👍 👍 👍

Show outdated Hide outdated package.json

@resin-io-versionbot resin-io-versionbot bot merged commit f106b95 into master Nov 27, 2017

5 checks passed

AutoMerges PR merging is in progress
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@resin-io-versionbot resin-io-versionbot bot deleted the ts-support branch Nov 27, 2017

@dfunckt

This comment has been minimized.

Show comment
Hide comment
@dfunckt

dfunckt Nov 27, 2017

Member

Thank you @pimterry @thgreasi 💯

Member

dfunckt commented Nov 27, 2017

Thank you @pimterry @thgreasi 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment