New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline the entire resin-cli-auth module #721

Merged
merged 3 commits into from Nov 27, 2017

Conversation

Projects
None yet
2 participants
@pimterry
Member

pimterry commented Nov 23, 2017

This is part of a general push to demodularize any code that isn't realistically reusable outside resin-cli, to make the codebase easier to manage and understand. Any code we have that nobody is going to want to use elsewhere should be moved into the core of the CLI itself.

Once this is merged, we can deprecate resin-cli-auth.

I've also removed all usages for underscore.string, since I noticed it as part of pulling in the dependencies from resin-cli-auth. It was a bit weird, and we don't really need it, so I've dropped it entirely.

This PR will conflict a little with #720, and the build probably won't pass until that's merged (because I haven't committed the build/ output, to limit the conflicts with that PR, which removes all build output). That's fine - as long as the tests pass and it only fails on uncommitted changes then here we're good, and everything should pass once the other PR is merged and this is rebased.

@pimterry pimterry requested a review from MoranF Nov 23, 2017

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Nov 23, 2017

Contributor

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

Contributor

resin-io-versionbot bot commented Nov 23, 2017

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Nov 23, 2017

Contributor

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

Contributor

resin-io-versionbot bot commented Nov 23, 2017

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

@pimterry

This comment has been minimized.

Show comment
Hide comment
@pimterry

pimterry Nov 23, 2017

Member

(Was failing with test failures, but this is now failing 'right' instead)

Member

pimterry commented Nov 23, 2017

(Was failing with test failures, but this is now failing 'right' instead)

pimterry added some commits Nov 23, 2017

Inline the entire resin-cli-auth module
This is part of a general push to demodularize any code that isn't
realistically reusable outside resin-cli, to make the codebase easier to
manage and understand. Once this is done, we'll deprecate the original
module itself.

Change-Type: patch
@pimterry

This comment has been minimized.

Show comment
Hide comment
@pimterry

pimterry Nov 27, 2017

Member

Now rebased on top of the now-merged #720, so this should be all passing and good to go if you're happy @MoranF.

Member

pimterry commented Nov 27, 2017

Now rebased on top of the now-merged #720, so this should be all passing and good to go if you're happy @MoranF.

@pimterry pimterry requested review from MoranF and removed request for MoranF Nov 27, 2017

@MoranF

MoranF approved these changes Nov 27, 2017

@resin-io-versionbot resin-io-versionbot bot merged commit 41ff793 into master Nov 27, 2017

4 of 5 checks passed

AutoMerges VersionBot should be used to merge PR
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@resin-io-versionbot resin-io-versionbot bot deleted the inline-cli-auth branch Nov 27, 2017

@pimterry pimterry referenced this pull request Nov 27, 2017

Merged

Deprecate resin-cli-auth #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment