New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate multicontainer package #742

Merged
merged 3 commits into from Dec 21, 2017

Conversation

Projects
None yet
2 participants
@pimterry
Member

pimterry commented Dec 21, 2017

Fixes #741, and also rebuilds the docs (since they haven't been updated, and I needed to build to test) en route.

We need to be careful not to use versionbot to publish anything using this until we're on master, and to always publish manually instead (which I expect will work fine in the short-term)

It wouldn't cause a big problem on this branch as things stand right now, but if you rebase over master, then any tagged pushes (e.g. via versionbot) will trigger a build & release of standalone build versions, which get published to github releases. We could do more complex things to fix that, but I don't think there's an easy solution there other than pull all that code back out entirely on this branch (I'd rather not) or separately namespacing with a fully forked repo. Seems easier to just skip versionbot until this is all ready.

Probably more we could do here, like updating the readme and docs, and all the internal help strings, to change all references to resin everywhere, but I'm going to assume this is enough for now.

@dfunckt dfunckt merged commit 5dcae8f into deploy-multi Dec 21, 2017

5 checks passed

AutoMerges Manual merging is in effect for this PR
Reviewers 1/1 review approvals met
Versionist Versioning for this PR is disabled
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dfunckt dfunckt deleted the separate-mc-package branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment