New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning for os configure, when passing a bare UUID #744

Merged
merged 2 commits into from Jan 2, 2018

Conversation

Projects
None yet
2 participants
@pimterry
Member

pimterry commented Dec 22, 2017

Reported here: https://www.flowdock.com/app/rulemotion/resin-frontend/threads/q_rtFK2qOo7tZcof2g4xrQKKptr

This now mentions the correct argument name (--device, not --uuid), and has been rephrased to make it clear that this does still work now, and it'll only stop working in the future.

Change-Type: patch

@pimterry pimterry requested review from horia-delicoti and MoranF Dec 22, 2017

@MoranF

MoranF approved these changes Dec 25, 2017

@resin-io-versionbot resin-io-versionbot bot merged commit 810ca78 into master Jan 2, 2018

7 checks passed

AutoMerges PR merging is in progress
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@resin-io-versionbot resin-io-versionbot bot deleted the fix-configure-deprecation-msg branch Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment