New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert windows paths to posix when passing to tar #751

Merged
merged 2 commits into from Jan 9, 2018

Conversation

Projects
None yet
4 participants
@pimterry
Member

pimterry commented Jan 9, 2018

#748 is an external PR from a fork, so doesn't work with versionbot. This PR is the same code, which versionbot has conveniently already version bumped (somewhat surprisingly - I think it's because the branch has the same name), but living on a local branch instead.

ashirley and others added some commits Jan 7, 2018

convert windows paths to posix when passing to tar
Due to mafintosh/tar-stream#3, the tar module
needs posix style paths but system-specific paths are being supplied

Change-Type: patch

@pimterry pimterry requested review from MoranF and thgreasi Jan 9, 2018

@lurch

This comment has been minimized.

Show comment
Hide comment
@lurch

lurch Jan 9, 2018

Adding a quick ping to @hedss just to make sure VersionBot doesn't fall over, or do something daft like double-version-bumping ;-)

lurch commented Jan 9, 2018

Adding a quick ping to @hedss just to make sure VersionBot doesn't fall over, or do something daft like double-version-bumping ;-)

@resin-io-versionbot resin-io-versionbot bot merged commit 158d471 into master Jan 9, 2018

7 checks passed

AutoMerges PR merging is in progress
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@resin-io-versionbot resin-io-versionbot bot deleted the fixWindowsPaths branch Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment