New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breakage in deploy command #754

Merged
merged 2 commits into from Jan 11, 2018

Conversation

Projects
None yet
2 participants
@pimterry
Member

pimterry commented Jan 11, 2018

One of the downsides of not having TS conversion everywhere yet: some of this code got broken in the latest changes, because the code that's using it doesn't get checked. Here:

  • Logger needs to be the direct export, not an exported property
  • Streams can't import Promise internally, because it breaks async function compilation. Instead, since this is a util only required on demand inside actions anyway, we just load things at the top level like normal people, and keep things simple.

@pimterry pimterry requested review from thgreasi and MoranF Jan 11, 2018

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Jan 11, 2018

Contributor

VersionBot failed to carry out a status check for the above pull request here: #754. The reason for this is:
2 of 5 required status checks have not succeeded: 1 expected and 1 pending.
Please carry out relevant changes or alert an appropriate admin.

Contributor

resin-io-versionbot bot commented Jan 11, 2018

VersionBot failed to carry out a status check for the above pull request here: #754. The reason for this is:
2 of 5 required status checks have not succeeded: 1 expected and 1 pending.
Please carry out relevant changes or alert an appropriate admin.

@resin-io-versionbot resin-io-versionbot bot merged commit 4e41261 into master Jan 11, 2018

7 checks passed

AutoMerges PR merging is in progress
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@resin-io-versionbot resin-io-versionbot bot deleted the fix-deploy branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment