New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include --emulated in the example resin build parameters #971

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
3 participants
@pimterry
Member

pimterry commented Sep 19, 2018

Nice suggestion from @samothx: https://www.flowdock.com/app/rulemotion/resin-frontend/threads/e1S3z92xsSmiFqFyFil3pRztsHK. This isn't strictly speaking always necessary (e.g. you might be building on an ARM box), but it won't cause problems, and the vast majority of users should be using it in the given example.

Change-type: patch
Signed-off-by: Tim Perry tim@resin.io

Include --emulated in the example resin build parameters
Change-type: patch
Signed-off-by: Tim Perry <tim@resin.io>

@pimterry pimterry requested review from thgreasi, CameronDiver and samothx Sep 19, 2018

@pimterry pimterry merged commit 21a3b82 into master Sep 19, 2018

16 of 17 checks passed

AutoMerges VersionBot should be used to merge PR
ResinCI/check-commits/commits Commit checks passed
Details
ResinCI/check-files/license license check passed
Details
ResinCI/check-files/readme readme check passed
Details
ResinCI/check-versionist/versionist Automatic versioning can be performed
Details
ResinCI/npm/linux-alpine-x86_64-node10
Details
ResinCI/npm/linux-alpine-x86_64-node6
Details
ResinCI/npm/linux-alpine-x86_64-node8
Details
ResinCI/npm/store-npm
Details
ResinCI/pr-base-is-master/base-branch Pr is against master
Details
ResinCI/store-github/store-github Will successfully increase version on master
Details
Reviewers 2/1 review approvals met
Versionist Found all required commit footer tags
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@pimterry pimterry deleted the add-emulated-to-build-docs branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment