New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: Don't allow creating devices with discontinued device types #398
Conversation
.then ([ deviceSlug, parentApplication ]) -> | ||
return Promise.all([ deviceManifestPromise, parentAppPromise ]) | ||
.then ([ deviceManifest, parentApplication ]) -> | ||
if deviceManifest.state == 'DISCONTINUED' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding
throw new errors.ResinInvalidDeviceType(deviceType) if !deviceManifest
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we discussed this at summit, and it is already covered by the .tap
check above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opps, forgot to approve right after!
…e types Connects-To: #358 Change-Type: major
2604056
to
174ea0c
Compare
Breaking: Don't allow creating devices with discontinued device types
Breaking: Don't allow creating devices with discontinued device types
Breaking: Don't allow creating devices with discontinued device types
Breaking: Don't allow creating devices with discontinued device types
Breaking: Don't allow creating devices with discontinued device types
This fixes this issue from a month or so ago: #358.
This is a breaking change (because users currently might be automatically creating
edge
devices, and that will now fail). To handle that, we're not going to merge this into master or use versionbot: we're going to merge quietly into a v7 branch for now, along with other upcoming breaking changes (API v3 & API keys), and then merge these all together with versionbot to master, to do a single breaking v7 release with all 3 included.Connects-To: #358
Change-Type: major (!!!)
HQ: resin-io/hq#785
See: resin-io/resin-ui#998
---- Autogenerated Waffleboard Connection: Connects to #358