New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that npm published files are always built afresh first #404

Merged
merged 2 commits into from Sep 28, 2017

Conversation

Projects
None yet
3 participants
@pimterry
Member

pimterry commented Sep 27, 2017

Included a prepack script too (though it's ignored in npm4), so publishing is still safe if you use npm5 locally.

@pimterry pimterry requested a review from thgreasi Sep 27, 2017

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Sep 27, 2017

Contributor

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

Contributor

resin-io-versionbot bot commented Sep 27, 2017

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

@thgreasi

🎆

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Sep 28, 2017

Contributor

VersionBot failed to carry out a status check for the above pull request here: #404. The reason for this is:
2 of 5 required status checks have not succeeded: 1 expected and 1 pending.
Please carry out relevant changes or alert an appropriate admin.

Contributor

resin-io-versionbot bot commented Sep 28, 2017

VersionBot failed to carry out a status check for the above pull request here: #404. The reason for this is:
2 of 5 required status checks have not succeeded: 1 expected and 1 pending.
Please carry out relevant changes or alert an appropriate admin.

@resin-io-versionbot resin-io-versionbot bot merged commit 61c6916 into master Sep 28, 2017

6 checks passed

AutoMerges PR merging is in progress
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@resin-io-versionbot resin-io-versionbot bot deleted the always-build-before-publish branch Sep 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment