New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a deprecation warning, plus other small tidyup #406

Merged
merged 7 commits into from Sep 29, 2017

Conversation

Projects
None yet
2 participants
@pimterry
Member

pimterry commented Sep 28, 2017

A few small fixes and tweaks spotted while doing the big v3 migration, pulled into a separate PR for nice easy reviewing.

@pimterry pimterry requested a review from thgreasi Sep 28, 2017

Show outdated Hide outdated lib/resin.coffee
Show outdated Hide outdated lib/resin.coffee
@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Sep 29, 2017

Contributor

VersionBot failed to commit a new version to prepare a merge for the above pull request here: #406. The reason for this is:
Cannot read property 'split' of undefined
Please carry out relevant changes or alert an appropriate admin.

Contributor

resin-io-versionbot bot commented Sep 29, 2017

VersionBot failed to commit a new version to prepare a merge for the above pull request here: #406. The reason for this is:
Cannot read property 'split' of undefined
Please carry out relevant changes or alert an appropriate admin.

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Sep 29, 2017

Contributor

VersionBot failed to commit a new version to prepare a merge for the above pull request here: #406. The reason for this is:
Cannot read property 'split' of undefined
Please carry out relevant changes or alert an appropriate admin.

Contributor

resin-io-versionbot bot commented Sep 29, 2017

VersionBot failed to commit a new version to prepare a merge for the above pull request here: #406. The reason for this is:
Cannot read property 'split' of undefined
Please carry out relevant changes or alert an appropriate admin.

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Sep 29, 2017

Contributor

VersionBot failed to carry out a status check for the above pull request here: #406. The reason for this is:
2 of 5 required status checks are pending.
Please carry out relevant changes or alert an appropriate admin.

Contributor

resin-io-versionbot bot commented Sep 29, 2017

VersionBot failed to carry out a status check for the above pull request here: #406. The reason for this is:
2 of 5 required status checks are pending.
Please carry out relevant changes or alert an appropriate admin.

@resin-io-versionbot resin-io-versionbot bot merged commit 85d9900 into master Sep 29, 2017

6 checks passed

AutoMerges PR merging is in progress
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@resin-io-versionbot resin-io-versionbot bot deleted the small-tidyup branch Sep 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment