New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to API v3 #418

Merged
merged 3 commits into from Oct 12, 2017

Conversation

Projects
None yet
3 participants
@pimterry
Member

pimterry commented Oct 11, 2017

Woo hoo - this moves the SDK to the new pine 5/api v3, updating all the relationships along the way, and hopefully finishing up 7.0.0. This has been made easier by the previous PRs removing lots of relationship logic entirely, but there's still quite a few left.

Note that while this doesn't break an enormous amount of code internally, it will break a huge amount of user code - anything that tries to follow relationships between models is going to have to be updated.

I'd definitely like your review on this to confirm before I merge @Page-, just in case I've missed something obvious.

Once this is done, I'm going to merge this into the v7 branch, do a last little bit of manual testing to double check things, and then I'm going to open a PR to master to look at, and get versionbot to do a 7.0.0 there release with everything in.

pimterry added some commits Sep 26, 2017

*BREAKING*: Upgrade to API v3. Main change is that all relationships …
…& result properties now include verbs (e.g. device.application is now device.belongs_to__application).

Change-Type: major
@thgreasi

This comment has been minimized.

Show comment
Hide comment
@thgreasi

thgreasi Oct 11, 2017

Member

Woohoo!

Member

thgreasi commented Oct 11, 2017

Woohoo!

@Page-

Page- approved these changes Oct 11, 2017

@@ -64,7 +64,6 @@ var resin = require('resin-sdk')({
Where the factory method accepts the following options:
* `apiUrl`, string, *optional*, is the resin.io API url. Defaults to `https://api.resin.io/`,
* `apiVersion`, string, *optional*, is the version of the API to talk to, like `v2`. Defaults to the current stable version: `v2`,

This comment has been minimized.

@Page-

Page- Oct 11, 2017

Contributor

Yeah, removing this makes a lot of sense

@Page-

Page- Oct 11, 2017

Contributor

Yeah, removing this makes a lot of sense

@pimterry pimterry merged commit 04c4c4f into v7 Oct 12, 2017

6 checks passed

AutoMerges Manual merging is in effect for this PR
Reviewers 1/1 review approvals met
Versionist Versioning for this PR is disabled
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

pimterry added a commit that referenced this pull request Oct 12, 2017

@pimterry pimterry referenced this pull request Oct 12, 2017

Merged

Release Resin-SDK v7.0.0 #420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment