New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application.generateProvisioningKey() #419

Merged
merged 2 commits into from Oct 12, 2017

Conversation

Projects
None yet
2 participants
@pimterry
Member

pimterry commented Oct 11, 2017

This change is already in the v7 branch, but I now need it in the CLI asap, and even once v7 is merged and released, I'm not expecting to upgrade the CLI for a couple of weeks, since there's no urgency there.

This relates to some flowdock discussion (https://www.flowdock.com/app/rulemotion/resin-frontend/threads/facwhqqAbHyMKMd5WQofDBQndNZ), which strongly suggests to me that we'll still need application keys indefinitely (to support old ResinOS versions), and that the change to remove that functionality entirely in #410 isn't safe. Can I get some thoughts on that here, from @Page- especially? If that's true then once this PR is merged I'll just strip the other one out entirely, and we'll end up just having support for both.

I've added a warning to generateApiKey anyway in the meantime, since most users shouldn't really be using it either way.

@pimterry pimterry requested review from Page- and thgreasi Oct 11, 2017

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Oct 11, 2017

Contributor

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

Contributor

resin-io-versionbot bot commented Oct 11, 2017

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

@Page-

Page- approved these changes Oct 12, 2017

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Oct 12, 2017

Contributor

VersionBot failed to carry out a status check for the above pull request here: #419. The reason for this is:
2 of 5 required status checks are pending.
Please carry out relevant changes or alert an appropriate admin.

Contributor

resin-io-versionbot bot commented Oct 12, 2017

VersionBot failed to carry out a status check for the above pull request here: #419. The reason for this is:
2 of 5 required status checks are pending.
Please carry out relevant changes or alert an appropriate admin.

@resin-io-versionbot resin-io-versionbot bot merged commit e5e1b3d into master Oct 12, 2017

6 checks passed

AutoMerges PR merging is in progress
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@resin-io-versionbot resin-io-versionbot bot deleted the provisioning-keys branch Oct 12, 2017

@pimterry pimterry referenced this pull request Oct 12, 2017

Merged

Release Resin-SDK v7.0.0 #420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment