New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier on build #446

Merged
merged 2 commits into from Dec 21, 2017

Conversation

Projects
None yet
2 participants
@pimterry
Member

pimterry commented Dec 19, 2017

From discussion on #445 (comment).

With this PR, we'll run prettier in CI, so failing to run it will fail the build, and it'll automatically get run if you run builds or tests locally, which should make it pretty hard to forget to do in the first place. Seems super quick right now. We can reconsider if it becomes a serious slowdown, but for the SDK use case I don't think it matters too much.

@pimterry pimterry requested a review from thgreasi Dec 19, 2017

@pimterry

This comment has been minimized.

Show comment
Hide comment
@pimterry

pimterry Dec 19, 2017

Member

We're hitting some new rate limiting problems in #445 - I'm going to resolve them there, merge that, then rebase this on top and these tests should start passing again 🤞

Member

pimterry commented Dec 19, 2017

We're hitting some new rate limiting problems in #445 - I'm going to resolve them there, merge that, then rebase this on top and these tests should start passing again 🤞

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Dec 19, 2017

Contributor

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

Contributor

resin-io-versionbot bot commented Dec 19, 2017

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Dec 21, 2017

Contributor

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

Contributor

resin-io-versionbot bot commented Dec 21, 2017

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Dec 21, 2017

Contributor

VersionBot failed to carry out a status check for the above pull request here: #446. The reason for this is:
2 of 5 required status checks have not succeeded: 1 expected and 1 pending.
Please carry out relevant changes or alert an appropriate admin.

Contributor

resin-io-versionbot bot commented Dec 21, 2017

VersionBot failed to carry out a status check for the above pull request here: #446. The reason for this is:
2 of 5 required status checks have not succeeded: 1 expected and 1 pending.
Please carry out relevant changes or alert an appropriate admin.

@resin-io-versionbot resin-io-versionbot bot merged commit 3108566 into master Dec 21, 2017

6 checks passed

AutoMerges PR merging is in progress
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@resin-io-versionbot resin-io-versionbot bot deleted the prettier-on-build branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment