New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further typing improvements #447

Merged
merged 6 commits into from Dec 21, 2017

Conversation

Projects
None yet
2 participants
@pimterry
Member

pimterry commented Dec 19, 2017

Previous typing PR #445 doesn't actually work, as we filter the published files in package.json, so they're not published.

This PR updates that, and adds a bunch more extra types that previously didn't exist at all, which I've run into as part of starting to convert the CLI (!!!). I've also pinned the typescript version to match the UI, just to make things simpler (I'm not sure but I think I hit some issues there, and making these match seems sensible).

Change-Type: patch

@pimterry pimterry requested a review from thgreasi Dec 19, 2017

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Dec 19, 2017

Contributor

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

Contributor

resin-io-versionbot bot commented Dec 19, 2017

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

debug?: boolean;
}
interface SdkConstructor {

This comment has been minimized.

@thgreasi

thgreasi Dec 20, 2017

Member

👍

@thgreasi

thgreasi Dec 20, 2017

Member

👍

Show outdated Hide outdated typings/resin-sdk.d.ts Outdated
@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Dec 20, 2017

Contributor

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

Contributor

resin-io-versionbot bot commented Dec 20, 2017

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

@pimterry pimterry requested a review from thgreasi Dec 20, 2017

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Dec 20, 2017

Contributor

VersionBot failed to carry out a status check for the above pull request here: #447. The reason for this is:
2 of 5 required status checks are pending.
Please carry out relevant changes or alert an appropriate admin.

Contributor

resin-io-versionbot bot commented Dec 20, 2017

VersionBot failed to carry out a status check for the above pull request here: #447. The reason for this is:
2 of 5 required status checks are pending.
Please carry out relevant changes or alert an appropriate admin.

@resin-io-versionbot resin-io-versionbot bot merged commit efeb05b into master Dec 21, 2017

5 of 6 checks passed

AutoMerges VersionBot should be used to merge PR
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@resin-io-versionbot resin-io-versionbot bot deleted the typing-improvements branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment