New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typescript to 2.6 #454

Merged
merged 2 commits into from Jan 10, 2018

Conversation

Projects
None yet
2 participants
@pimterry
Member

pimterry commented Jan 10, 2018

Upgrading (and fixing the one change it requires). Needed because I want 2.6 in the CLI, as it includes a fix for an annoying bug with async function compilation.

This won't break anything in the UI (since nothing there uses raw filters, and that's all that's changed), but we should probably look at upgrading there too soon, so we don't fall behind and have more work to do later, and so we get all the nice new features/bug fixes/better type checks/etc like JSX fragments sooner.

I'm going to take a look at the UI side of this in a sec (although it'll require this to get released and an upgrade to SDK 8 there first)

@pimterry pimterry requested review from thgreasi and LucianBuzzo Jan 10, 2018

@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Jan 10, 2018

Contributor

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

Contributor

resin-io-versionbot bot commented Jan 10, 2018

@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit.

@thgreasi

👍

Upgrade typescript to 2.6
Change-Type: patch
@resin-io-versionbot

This comment has been minimized.

Show comment
Hide comment
@resin-io-versionbot

resin-io-versionbot bot Jan 10, 2018

Contributor

VersionBot failed to carry out a status check for the above pull request here: #454. The reason for this is:
2 of 5 required status checks are pending.
Please carry out relevant changes or alert an appropriate admin.

Contributor

resin-io-versionbot bot commented Jan 10, 2018

VersionBot failed to carry out a status check for the above pull request here: #454. The reason for this is:
2 of 5 required status checks are pending.
Please carry out relevant changes or alert an appropriate admin.

@resin-io-versionbot resin-io-versionbot bot merged commit bd0aa98 into master Jan 10, 2018

6 checks passed

AutoMerges PR merging is in progress
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@resin-io-versionbot resin-io-versionbot bot deleted the upgrade-ts branch Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment