New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak CSS to line up correctly on more screen sizes #153

Merged
merged 2 commits into from Jan 10, 2018

Conversation

Projects
None yet
2 participants
@pimterry
Member

pimterry commented Jan 2, 2018

Some tweaks based on this conversation from a little while back: https://www.flowdock.com/app/rulemotion/resin-projects/threads/mNyvllwsx4lhMx1IbM7Watp-Lic

I did some light testing. All the basic responsiveness seems to work everywhere for me, and there's nothing obviously broken, but the button margins definitely do odd things with this button on mobile, as it hasn't been correctly put into the grid like the other form groups. These little tweaks seem to make everything line up nicely everywhere I checked.

Change-Type: patch

@pimterry pimterry requested a review from majorz Jan 2, 2018

@majorz

majorz approved these changes Jan 10, 2018

Thanks Tim!

@resin-io-versionbot resin-io-versionbot bot merged commit aa6ac4a into master Jan 10, 2018

9 checks passed

AutoMerges PR merging is in progress
Reviewers 1/1 review approvals met
Versionist Found all required commit footer tags
ci/circleci: aarch64 Your tests passed on CircleCI!
Details
ci/circleci: amd64 Your tests passed on CircleCI!
Details
ci/circleci: armv7hf Your tests passed on CircleCI!
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: i386 Your tests passed on CircleCI!
Details
ci/circleci: rpi Your tests passed on CircleCI!
Details

@resin-io-versionbot resin-io-versionbot bot deleted the responsive-tweaks branch Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment