Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the corner's radius customizable with border_radius param in .i3/config #3

Merged
merged 2 commits into from Jul 3, 2019

Conversation

@AlisCode
Copy link

commented Jul 3, 2019

Hi @resloved ,

Good job on forking i3 and adding rounded corners. It's brilliant !
I noticed that you hardcoded the radius in the x.c file, so I went ahead and made it easier for a user of your fork to change this value. Otherwise, one would need to read the code, change the value, compile and install.

This PR allows a user to customize the corner's radius by putting the line "border_radius <number>" in their i3 config file. Simple ! :)

Copy link
Owner

left a comment

Thanks for the pull request! Looks fine and seems to work as intended. Since this fork may eventually be merged into i3 we shouldn't have rounded corners on by default. I understand that it may prevent some confusion for those that just want this fork, but it should probably be done sooner then later. Just remove the defaults in x_shape_title and x_shape_window and I'll go ahead and merge.

@AlisCode

This comment has been minimized.

Copy link
Author

commented Jul 3, 2019

Done :)

@resloved resloved merged commit 0018167 into resloved:shape Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.