Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined variable: parameter in /srv/lg/routers/cisco_iosxr.php on line 71 #67

Closed
markeganfuller opened this issue May 3, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@markeganfuller
Copy link
Contributor

commented May 3, 2019

PHP message: PHP Notice:  Undefined variable: parameter
in /srv/lg/routers/cisco_iosxr.php on line 71

This appears to be happening because of a mix of $parameter and $destination in cisco_iosxr.php:

-  protected function build_traceroute($destination) {
+  protected function build_traceroute($parameter) {

A grep also flags extreme_netiron.php and juniper.php.

Whilst fixing this I also found:

PHP Fatal error:  Uncaught Error: Call to undefined method ExtremeNetIron::add()
in /var/www/html/routers/extreme_netiron.php:44

Which seems to just be a typo of $this instead of $cmd:

-      $this->add('detail');
+      $cmd->add('detail');

@respawner respawner self-assigned this May 3, 2019

@respawner respawner added the bug label May 3, 2019

@respawner respawner closed this in #68 May 3, 2019

respawner added a commit that referenced this issue May 3, 2019

Closes #67: Fix coding errors.
* Fix mixture of destination and parameter.
* Fix undefined method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.