URI-encode-on-open-html-file #398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manojVivek
reviewed
Aug 18, 2020
| // code to encode | ||
| // file URI | ||
| p1 = encodeURIComponent(filePath); | ||
| const url = `file://${filePath + p1}`; |
There was a problem hiding this comment.
@aUsefulMethod Isn't filePath + p1 going to repeat the path twice?
There was a problem hiding this comment.
maybe not work ... encodeURIComponent encode all of string :D
|
@aUsefulMethod Can you please attach a screenshot of how the address bar looks after the encoding? |
|
I’m currently in school, I’ll close this PR when I get a chance.
|
|
Hi @aUsefulMethod we are going with #415, we think that is a better approach. Thanks anyway and we are looking forward to more collaboration in the future! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm able to open .html files with # in name when opening with responsively. I've tested a few other reserved characters and it seems to be working as well.