Permalink
Show file tree
Hide file tree
7 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Added ability to use
multi and pipelined commands along with corr…
…esponding specs
- Loading branch information
Showing
2 changed files
with
36 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ef30e9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what yet, but this commit broke Resque's tests :(
7ef30e9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is not threadsafe? I will try to look at this a little closer and pull down resque's test suite.
7ef30e9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled down the latest master branch of resque.
I tried running the tests against the redis-namespace version specified in resque's gemspec, tests passed. I tried running the tests against the master HEAD of redis-namespace (which includes this commit), tests passed. I then did
git co -b test-fix 7ef30e91and ran the reque tests against that commit specifically, and the tests still passed for me.I'd be happy to look at this closer if you could let me know what test is failing for you.
7ef30e9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7ef30e9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7ef30e9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A
git checkout 7ef30e91878689d0411d4b962d6835778335b0bfandrakeyields a clean test run for me7ef30e9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which legacy test in resque led you down this way? I can take a look there too :-)