Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only support modern rubies #1060

Merged
merged 1 commit into from Jun 28, 2013
Merged

Conversation

jacobo
Copy link

@jacobo jacobo commented Jun 26, 2013

how about it?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d6c978c on engineyard:modern_ruby into 543fbec on resque:master.

@steveklabnik
Copy link
Member

I am tempted to say this is acceptable for 2.0, as long as we provide bug backports for 1.x. I'm going to post to the mailing list to see what people think.

@ekampp
Copy link

ekampp commented Jun 27, 2013

I agree with @steveklabnik that it would be fine for the next, major version (2.0).

In general, if it becomes a burning platform, at some point, you need to cut support. And cutting that with the next major version fits with the semver scheme.

@steveklabnik
Copy link
Member

Straight from the horse's mouth: https://twitter.com/steveklabnik/status/350521242081697792

I'm going to merge this for now, since it's been a few days and nobody has raised any significant issues. However, until the actual release, I consider this an open discussion topic. I'm fine with doing this as long as we continue to provide bugfixes for 1-x-stable for the people who are still stuck on 1.8.

steveklabnik added a commit that referenced this pull request Jun 28, 2013
@steveklabnik steveklabnik merged commit b9a9923 into resque:master Jun 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants