-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backport of before_pause & after_pause hooks #1334
Conversation
when this was backported to 1.x-stable in 14cb8a9, the wrong test name was copied in
Yep, I +1 this. |
Hey there! It's been a while, sorry about that. @steveklabnik and I are going to be working on Resque again, but this PR needs some attention. If you get the chance, would you mind making the tests pass, if you're up for it. If you're not up for it, that's cool, just let us know so we can investigate |
No worries on the wait, I totally understand! I'm totally happy to help investigate the specs failing. It likes like the specs are all passing except on ruby
After digging through some other pull-requests, I noticed that #1343 also failed for the same reason. Any ideas as to what the root of this issue might be? Could something in this changeset have introduced that error? |
Hi @stevenschobert; good question. I closed out that PR because I didn't realize that there were separate gemfiles for 1.8.7 and 1.9.2. Once I get that cleared up I'll rerun and see what the output looks like. |
Looks like these failures are not deterministic... which makes sense, since they rely on forking another process. I'm unable to repro locally right now, but will keep trying. |
Fix backport of before_pause & after_pause hooks
Thanks so much for this! |
@steveklabnik @hoffmanc Thank you both! Happy I was able to help! |
Heya awesome folks! Thank you for all awesome work that goes into resque 🎉
I ran into a small issue today, in the
1-x-stable
version (v1.25.2
), wherebefore_pause
andafter_pause
hooks would never get called. Workers are still paused correctly, they just don't fire their associated hooks.After a bit of digging, I think there was just a small mixup in #831 when the hooks got backported to
1-x-stable
(which is awesome by the way, ❤️ for the backport).I've added in the
run_hook
calls to thepause_processing
andunpause_processing
methods respectively, and added specs to cover the change.Cheers! Please let me know if there's anything else I can do!