Fixed filter log statement to allow for resque job.rb patching. #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… paths like ./lib/extensions/resque/job.rb are in play
|
Any update |
1 similar comment
|
Any update |
|
This seems reasonable enough to me, although I don't entirely understand the issue it's solving. Could you just please add an entry to HISTORY.md in the |
jeremy
reviewed
Feb 12, 2018
There was a problem hiding this comment.
This would indeed clean lib/myextension/etc/resque/job.rb, but to anyone reading the code it'd look like a lucky accident.
If we want to support other backtrace cleaning approaches, let's do it in a clear, direct manner, like taking a backtrace_cleaner: … in Resque::Failure::Base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed lib dependency. Causes error when gem/lib/resque/job.rb where paths like ./lib/extensions/resque/job.rb are in play