Skip to content

Escape HTML from the params to avoid XSS #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2022

Conversation

madslundholmdk
Copy link
Contributor

After a penetration test, there were multiple Reflected XSS vulnerabilities found in the the web interface.

The following paths has been found vulnerable:

  • /failed/?class=<script>alert(document.cookie)</script>
  • /queues/><img src=a onerror=alert(document.cookie)>

I have look through the other views, and found other places where HTML wasn't escaped from the params.

@iloveitaly
Copy link
Contributor

Great change, thank you!

@iloveitaly iloveitaly merged commit ee99d2e into resque:master Mar 27, 2022
jwoodrow pushed a commit to moonproject/resque that referenced this pull request Aug 5, 2022
* Escape HTML from the params to avoid XSS

* Only escape the param when it's printed to the DOM
jwoodrow added a commit to moonproject/resque that referenced this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants