New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:public is no longer used in Sinatra 1.3+ to avoid overloading Module#pub #420

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@guilleiguaran
Contributor

guilleiguaran commented Oct 6, 2011

:public is no longer used in Sinatra 1.3+ to avoid overloading Module#public, use :public_folder instead

@casiodk

This comment has been minimized.

Show comment
Hide comment
@casiodk

casiodk Oct 10, 2011

I´m getting this quite a lot too

casiodk commented Oct 10, 2011

I´m getting this quite a lot too

@tjeden

This comment has been minimized.

Show comment
Hide comment
@tjeden

tjeden Oct 10, 2011

+1 it's quite annoying.

tjeden commented Oct 10, 2011

+1 it's quite annoying.

@greinacker

This comment has been minimized.

Show comment
Hide comment
@greinacker

greinacker Oct 10, 2011

Not saying it's ideal, but as a workaround, you can use Sinatra 1.2.6 until this gets fixed...

gem 'sinatra', '1.2.6'

greinacker commented Oct 10, 2011

Not saying it's ideal, but as a workaround, you can use Sinatra 1.2.6 until this gets fixed...

gem 'sinatra', '1.2.6'

@dolzenko

This comment has been minimized.

Show comment
Hide comment
@dolzenko

dolzenko commented Oct 13, 2011

+1

@casiodk

This comment has been minimized.

Show comment
Hide comment
@casiodk

casiodk Oct 13, 2011

You could just do

bundle open resque

and change the line youself ? in server.rb line 12 :public => :public_folder

casiodk commented Oct 13, 2011

You could just do

bundle open resque

and change the line youself ? in server.rb line 12 :public => :public_folder

@d11wtq

This comment has been minimized.

Show comment
Hide comment
@d11wtq

d11wtq Dec 14, 2011

Just curious. When is a release going out that will include this? We've been getting these deprecation warnings for over two months now and not a single release has been made in that time? Is there some sort of blocker that is delaying pushing a new gem? Anything we can help with?

d11wtq commented Dec 14, 2011

Just curious. When is a release going out that will include this? We've been getting these deprecation warnings for over two months now and not a single release has been made in that time? Is there some sort of blocker that is delaying pushing a new gem? Anything we can help with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment