Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added buttons to better navigate through tasks #772

Merged
merged 2 commits into from Dec 12, 2012
Merged

added buttons to better navigate through tasks #772

merged 2 commits into from Dec 12, 2012

Conversation

esse
Copy link

@esse esse commented Dec 12, 2012

Hi,

in this pull request I've added two more links to failed and queues tab: to navigate to end of list and to navigate to beginning of list.

I believe this will simplify a little bit navigation through resque-web interface.

@@ -1,10 +1,17 @@
<% if start - 20 >= 0 || start + 20 <= size %>
<p class='pagination'>
<% if start - 20 >= 0 %>
<a href="<%= current_page %>?start=<%= start - 20 %>" class='less'>&laquo; less</a>
&nbsp;<a href="<%= current_page %>?start=0" class='less separated-right'>&laquo;&laquo;</a>&nbsp;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the &nbsp; directives really need to be there?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, not really. I'll remove it, thanks!

@ecoffey
Copy link
Member

ecoffey commented Dec 12, 2012

This looks really handy, but I do believe @steveklabnik and crew were holding off on resque-web PRs till post-2.0, since it's going to be spun off into a separate gem.

Keep on eye on that, and send it again when appropriate :-)

@esse
Copy link
Author

esse commented Dec 12, 2012

@ecoffey - this actually very small change and it's really annoying to type start manually each time. so I'm hoping maybe it can get incorporated right now ;)

@ecoffey
Copy link
Member

ecoffey commented Dec 12, 2012

@esse definitely agree with you, was just giving you a heads up :-)

@steveklabnik
Copy link
Member

Yes, this is super tiny, so I'll make an exception.

I really need to fix this JRuby stuff :(

steveklabnik added a commit that referenced this pull request Dec 12, 2012
added buttons to better navigate through tasks
@steveklabnik steveklabnik merged commit ec01a20 into resque:master Dec 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants