Minor refactoring of the Worker internals #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einarj
commented
Apr 26, 2013
einarj
commented
- Moved @child reset from #work into #process_job
- Moved work loop into its own method
* Moved @child reset from #work into #process_job * Moved work loop into its own method
|
This is the result of a #pairwithme session with @steveklabnik |
|
Ha! Of course we'd miss the block parameter! How silly! |
|
Yeah, I smacked my head as soon as I noticed that :) |
steveklabnik
added a commit
that referenced
this pull request
Apr 26, 2013
Minor refactoring of the Worker internals
|
Green! Awesome! :D |
|
Thanks again for an awesome session. |
|
My pleasure :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.