Remove AbstractResponse#to_i, which is too unexpected, considering:#103
Merged
ab merged 1 commit intorest-client:masterfrom Mar 14, 2015
Merged
Remove AbstractResponse#to_i, which is too unexpected, considering:#103ab merged 1 commit intorest-client:masterfrom
ab merged 1 commit intorest-client:masterfrom
Conversation
Contributor
godfat
commented
Nov 29, 2011
require 'webmock'
require 'rest-client'
WebMock::API.stub_request(:get, 'http://host/').to_return(:body => '123')
RestClient.get('http://host/') # "123"
RestClient.get('http://host/').to_s # "123"
RestClient.get('http://host/').to_str # "123"
RestClient.get('http://host/').class # String
RestClient.get('http://host/').to_i # 200
RestClient.get('http://host/').to_s.to_i # 200
RestClient.get('http://host/').to_str.to_i # 200
String(RestClient.get('http://host/')).to_i # 200
RestClient.get('http://host/').dup.to_i # 123
String.new(RestClient.get('http://host/')).to_i # 123
"#{RestClient.get('http://host/')}".to_i # 123
RestClient.get('http://host/').clone.to_i # 200
|
+1 for this, i just wasted too much time on this... |
Member
|
(For reference only: This is one of many patches included in #106.) |
|
+1 please |
Member
|
Ugh, this behavior is painful. I'm wary of removing it outright though, since it's been around for so long, and people might be relying on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.