RESTEASY-2099 (#1850)

* RESTEASY-2099 Fix the 3 failed resteasy-link tests after replacing jettison with jackson * fix done * - split XML and JSON tests into two tests because now they are using separate JAXB and Jackson providers. - Remove not-used code * remove useless commented code * clear spaces to pass checkstyle tests
resteasy · Feb 1, 2019 · 13d9648 · 13d9648
1 parent 20b23eb
commit 13d9648
Show file tree

Hide file tree

Showing 11 changed files with 52 additions and 77 deletions.
diff --git a/resteasy-links/src/main/java/org/jboss/resteasy/links/impl/JsonLinkDecorator.java b/resteasy-links/src/main/java/org/jboss/resteasy/links/impl/JsonLinkDecorator.java
@@ -10,6 +10,7 @@
 import javax.ws.rs.core.MediaType;
 import javax.ws.rs.core.UriInfo;
 import java.lang.annotation.Annotation;
+import java.util.Collection;
 
 public class JsonLinkDecorator implements DecoratorProcessor<DecoratedEntityContainer, AddLinks> {
 
@@ -19,7 +20,15 @@ public DecoratedEntityContainer decorate(DecoratedEntityContainer target, AddLin
       ResourceMethodRegistry registry = (ResourceMethodRegistry) ResteasyContext.getContextData(Registry.class);
 
       // find all rest service classes and scan them
-      RESTUtils.addDiscovery(target.getEntity(), uriInfo, registry);
+      if (Collection.class.isAssignableFrom(target.getEntity().getClass())) {
+         Collection coll = (Collection) target.getEntity();
+         for (Object entity : coll) {
+            RESTUtils.addDiscovery(entity, uriInfo, registry);
+         }
+      } else {
+         RESTUtils.addDiscovery(target.getEntity(), uriInfo, registry);
+      }
+
       return target;
    }
 }
diff --git a/resteasy-links/src/test/java/org/jboss/resteasy/links/test/Book.java b/resteasy-links/src/test/java/org/jboss/resteasy/links/test/Book.java
@@ -72,13 +72,13 @@ public void setComments(List<Comment> comments) {
       this.comments = comments;
    }
 
-   public void addComment(int id, String text){
+   public void addComment(String id, String text){
       comments.add(new Comment(id, text, this));
    }
 
    public Comment getComment(int commentId) {
       for(Comment c : comments)
-         if(c.getId() == commentId)
+         if(c.getId().equals(commentId))
             return c;
       return null;
    }

diff --git a/resteasy-links/src/test/java/org/jboss/resteasy/links/test/BookStore.java b/resteasy-links/src/test/java/org/jboss/resteasy/links/test/BookStore.java
@@ -33,8 +33,8 @@ public class BookStore {
 
    {
       Book book = new Book("foo", "bar");
-      book.addComment(0, "great book");
+      book.addComment(Integer.toString(0), "great book");
-      book.addComment(1, "terrible book");
+      book.addComment(Integer.toString(1), "terrible book");
       books.put(book.getTitle(), book);
    }
 
@@ -160,5 +160,4 @@ public void deleteComment(@PathParam("id") String bookId, @PathParam("cid") int
       Comment c = book.getComment(commentId);
       book.getComments().remove(c);
    }
-
 }
diff --git a/resteasy-links/src/test/java/org/jboss/resteasy/links/test/BookStoreMinimal.java b/resteasy-links/src/test/java/org/jboss/resteasy/links/test/BookStoreMinimal.java
@@ -33,8 +33,9 @@ public class BookStoreMinimal {
 
    {
       Book book = new Book("foo", "bar");
-      book.addComment(0, "great book");
+      book.addComment(Integer.toString(0), "great book");
-      book.addComment(1, "terrible book");
+      book.addComment(Integer.toString(1), "terrible book");
+
       books.put(book.getTitle(), book);
    }
 

diff --git a/resteasy-links/src/test/java/org/jboss/resteasy/links/test/Comment.java b/resteasy-links/src/test/java/org/jboss/resteasy/links/test/Comment.java
@@ -13,42 +13,48 @@
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
 public class Comment {
-   public int id;
+
+   @XmlAttribute
+   @XmlID
+   public String id;
+
    @XmlElement
    public String text;
    @ParentResource
    public Book book;
 
    @XmlElement
-   // These both fail deserialisation for some reason
-//   @XmlElement(name = "link", namespace = "http://www.w3.org/2005/Atom")
-//   @XmlElementRef
    private RESTServiceDiscovery rest;
 
    public Comment() {
    }
 
-   public Comment(final int id, final String text, final Book book) {
+   public Comment(final String id, final String text, final Book book) {
       this.id = id;
       this.text = text;
       this.book = book;
    }
 
-   public int getId() {
+   public String getId() {
       return id;
    }
-   public void setId(int id) {
+
+   public void setId(String id) {
       this.id = id;
    }
+
    public String getText() {
       return text;
    }
+
    public void setText(String text) {
       this.text = text;
    }
+
    public Book getBook() {
       return book;
    }
+
    public void setBook(Book book) {
       this.book = book;
    }
@@ -60,11 +66,4 @@ public RESTServiceDiscovery getRest() {
    public void setRest(RESTServiceDiscovery rest) {
       this.rest = rest;
    }
-
-   // JAXB wants an ID to be a String...
-   @XmlAttribute
-   @XmlID
-   public String getXMLID(){
-      return Integer.toString(id);
-   }
 }
diff --git a/resteasy-links/src/test/java/org/jboss/resteasy/links/test/SecureBookStore.java b/resteasy-links/src/test/java/org/jboss/resteasy/links/test/SecureBookStore.java
@@ -23,8 +23,8 @@ public class SecureBookStore {
 
    {
       Book book = new Book("foo", "bar");
-      book.addComment(0, "great book");
+      book.addComment(Integer.toString(0), "great book");
-      book.addComment(1, "terrible book");
+      book.addComment(Integer.toString(1), "terrible book");
       books.put(book.getTitle(), book);
    }
 

diff --git a/resteasy-links/src/test/java/org/jboss/resteasy/links/test/SecureBookStoreMinimal.java b/resteasy-links/src/test/java/org/jboss/resteasy/links/test/SecureBookStoreMinimal.java
@@ -23,8 +23,8 @@ public class SecureBookStoreMinimal {
 
    {
       Book book = new Book("foo", "bar");
-      book.addComment(0, "great book");
+      book.addComment(Integer.toString(0), "great book");
-      book.addComment(1, "terrible book");
+      book.addComment(Integer.toString(1), "terrible book");
       books.put(book.getTitle(), book);
    }
 

diff --git a/resteasy-links/src/test/java/org/jboss/resteasy/links/test/TestFacadeLinks.java b/resteasy-links/src/test/java/org/jboss/resteasy/links/test/TestFacadeLinks.java
@@ -24,7 +24,6 @@
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.BeforeClass;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -89,12 +88,14 @@ public void after(){
    }
 
    @Test
-   @Ignore
+   public void testLinksXML() throws Exception {
-   public void testLinks() throws Exception
-   {
       ScrollableCollection comments = client.getScrollableCommentsXML("foo", "book");
       checkCommentsLinks(url, comments);
-      comments = client.getScrollableCommentsJSON("foo", "book");
+   }
+
+   @Test
+   public void testLinksJSON() throws Exception {
+      ScrollableCollection comments = client.getScrollableCommentsJSON("foo", "book");
       checkCommentsLinks(url, comments);
    }
 
@@ -124,36 +125,4 @@ private void checkCommentsLinks(String url, ScrollableCollection comments) {
       Assert.assertNotNull(atomLink);
       Assert.assertEquals(url+"/", atomLink.getHref());
    }
-
-   private void checkCommentLinks(String url, Comment comment) {
-      Assert.assertNotNull(comment);
-      Assert.assertEquals(0, comment.getId());
-      RESTServiceDiscovery links = comment.getRest();
-      Assert.assertNotNull(links);
-      Assert.assertEquals(6, links.size());
-      // self
-      AtomLink atomLink = links.getLinkForRel("self");
-      Assert.assertNotNull(atomLink);
-      Assert.assertEquals(url+"/book/foo/comment/0", atomLink.getHref());
-      // update
-      atomLink = links.getLinkForRel("update");
-      Assert.assertNotNull(atomLink);
-      Assert.assertEquals(url+"/book/foo/comment/0", atomLink.getHref());
-      // remove
-      atomLink = links.getLinkForRel("remove");
-      Assert.assertNotNull(atomLink);
-      Assert.assertEquals(url+"/book/foo/comment/0", atomLink.getHref());
-      // list
-      atomLink = links.getLinkForRel("list");
-      Assert.assertNotNull(atomLink);
-      Assert.assertEquals(url+"/book/foo/comments", atomLink.getHref());
-      // add
-      atomLink = links.getLinkForRel("add");
-      Assert.assertNotNull(atomLink);
-      Assert.assertEquals(url+"/book/foo/comments", atomLink.getHref());
-      // collection
-      atomLink = links.getLinkForRel("collection");
-      Assert.assertNotNull(atomLink);
-      Assert.assertEquals(url+"/book/foo/comment-collection", atomLink.getHref());
-   }
 }
diff --git a/resteasy-links/src/test/java/org/jboss/resteasy/links/test/TestLinks.java b/resteasy-links/src/test/java/org/jboss/resteasy/links/test/TestLinks.java
@@ -24,11 +24,9 @@
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.BeforeClass;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
-import org.junit.runners.Parameterized.Parameters;
 
 @RunWith(Parameterized.class)
 public class TestLinks
@@ -54,7 +52,7 @@ public static void afterClass() throws Exception
       dispatcher = null;
    }
 
-   @Parameters
+   @Parameterized.Parameters
    public static List<Class<?>[]> getParameters(){
       return Arrays.asList(new Class<?>[]{BookStore.class}, new Class<?>[]{BookStoreMinimal.class});
    }
@@ -90,29 +88,29 @@ public void after(){
 
    @Test
    public void testLinksXML() throws Exception {
-
          Book book = client.getBookXML("foo");
          checkBookLinks1(url, book);
 
    }
 
    @Test
    public void testLinksJson() throws Exception {
-
          Book book = client.getBookJSON("foo");
          checkBookLinks1(url, book);
-
    }
 
    @Test
-   @Ignore
+   public void testCommentsXML() throws Exception
-   public void testComments() throws Exception
    {
       List<Comment> comments = client.getBookCommentsXML("foo");
       Assert.assertNotNull(comments);
       Assert.assertFalse(comments.isEmpty());
       checkCommentLinks(url, comments.get(0));
-      comments = client.getBookCommentsJSON("foo");
+   }
+
+   @Test
+   public void testCommentsJson() throws Exception {
+      List<Comment> comments = client.getBookCommentsJSON("foo");
       Assert.assertNotNull(comments);
       Assert.assertFalse(comments.isEmpty());
       checkCommentLinks(url, comments.get(0));
@@ -157,7 +155,7 @@ private void checkBookLinks1(String url, Book book) {
 
    private void checkCommentLinks(String url, Comment comment) {
       Assert.assertNotNull(comment);
-      Assert.assertEquals(0, comment.getId());
+      Assert.assertEquals(Integer.toString(0), comment.getId());
       RESTServiceDiscovery links = comment.getRest();
       Assert.assertNotNull(links);
       Assert.assertEquals(6, links.size());

diff --git a/resteasy-links/src/test/java/org/jboss/resteasy/links/test/el/BookStoreInvalidEL.java b/resteasy-links/src/test/java/org/jboss/resteasy/links/test/el/BookStoreInvalidEL.java
@@ -18,8 +18,8 @@ public class BookStoreInvalidEL {
 
    {
       Book book = new Book("foo", "bar");
-      book.addComment(0, "great book");
+      book.addComment(Integer.toString(0), "great book");
-      book.addComment(1, "terrible book");
+      book.addComment(Integer.toString(1), "terrible book");
       books.put(book.getTitle(), book);
    }
 

diff --git a/resteasy-links/src/test/java/org/jboss/resteasy/links/test/el/BookStoreNoPackage.java b/resteasy-links/src/test/java/org/jboss/resteasy/links/test/el/BookStoreNoPackage.java
@@ -18,8 +18,8 @@ public class BookStoreNoPackage {
 
    {
       Book book = new Book("foo", "bar");
-      book.addComment(0, "great book");
+      book.addComment(Integer.toString(0), "great book");
-      book.addComment(1, "terrible book");
+      book.addComment(Integer.toString(1), "terrible book");
       books.put(book.getTitle(), book);
    }