RESTEASY-2324: RESTEasy client should disable Apache Http Client cookie management feature by default #2135
Conversation
|
I don' t know why but one travis build failed... |
asoldano
left a comment
asoldano
left a comment
There was a problem hiding this comment.
Thanks for the PR @NicoNes . On top of the request for changes below, I'm wondering wether we should have a mention to this in the documentation, otherwise users might simply wonder why their cookies do not work by default... WDYT?
| log.info("starting testSessionScope()"); | ||
| client.close(); | ||
| client = ClientBuilder.newClient(); | ||
| client = new ResteasyClientBuilderImpl().cookieManagementEnabled(true).build(); |
There was a problem hiding this comment.
Please do not reference the ResteasyClientBuilderImpl directly; use:
client = ((ResteasyClientBuilder)(ClientBuilder.newBuilder())).cookieManagementEnabled(true).build();
| @BeforeClass | ||
| public static void init() { | ||
| client = ClientBuilder.newClient(); | ||
| client = new ResteasyClientBuilderImpl().cookieManagementEnabled(true).build(); |
Signed-off-by: NicoNes <nicolas.nesmon@gmail.com>
…yClientBuilderImpl. - Enrich userguide Signed-off-by: NicoNes <nicolas.nesmon@gmail.com>
NicoNes
force-pushed
the
RESTEASY-2324
branch
from
f8013b7 to
19b41da
Compare
|
Hi @asoldano , You're right we should add documentation about this. Thanks |
|
@NicoNes sorry for the late feedback. Thanks for the addition to the doc. I'm merging this because I don't want to make the process over complicated. However, I've just realized that it would probably be better to have a |
|
Hey @asoldano, I thought about it when I did it and I hesitated because, once But as you said it's already the case for other methods so let's keep it consistent. Thanks ! |
|
Follow-up on #2169 |
…ent cookie management feature by default (resteasy#2135)" This reverts commit 2edbeaa.
4 participants
No description provided.