Disable Hashie warnings for re-defined methods such as length #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any `Client#describe` class currently results in lots of ``` You are setting a key that conflicts with a built-in method Restforce::Mash#length defined in Hash. This can cause unexpected behavior when accessing the key via as a property. You can still access the key via the #[] method. ``` warnings, bc. of the “fields”-Array as “fields” have a “length” key. The logging layer of Hashie was introduced in `hashie v3.5.0`. And the disable_warnings method was introduced in `hashie v3.5.2`. See https://github.com/intridea/hashie/blob/master/CHANGELOG.md
|
👍 |
timrogers
pushed a commit
that referenced
this pull request
Apr 3, 2017
* Ensure `Restforce::Middleware::Logger` is the last Faraday middleware to be called so everything is properly logged (including the effects of the `Gzip` and `CustomHeaders` middlewares which were previously running after it) (@jonnymacs) * Suppress [Hashie](https://github.com/intridea/hashie) warnings when using Hashie v3.5.0 or later (see [#295](#295) for details) (@janraasch)
risenforward
pushed a commit
to risenforward/sfapi20
that referenced
this pull request
Dec 21, 2018
* Ensure `Restforce::Middleware::Logger` is the last Faraday middleware to be called so everything is properly logged (including the effects of the `Gzip` and `CustomHeaders` middlewares which were previously running after it) (@jonnymacs) * Suppress [Hashie](https://github.com/intridea/hashie) warnings when using Hashie v3.5.0 or later (see [#295](restforce/restforce#295) for details) (@janraasch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue fixed by this pr
When using
hashie >= v3.5.0anyClient#describecall currently results in lots ofwarnings, bc. of the
fields-Array asfieldshave alengthkey.Background
The logging layer of Hashie was introduced in
hashie v3.5.0. And thedisable_warningsmethod was introduced inhashie v3.5.2. See https://github.com/intridea/hashie/blob/master/CHANGELOG.md.Other gems using
hashiewent this way as well, see for example elastic/elasticsearch-rails#666.