Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder changelog/unreleased/ doesn't exist when empty #2485

Closed
rawtaz opened this issue Nov 22, 2019 · 5 comments · Fixed by #2486
Closed

Folder changelog/unreleased/ doesn't exist when empty #2485

rawtaz opened this issue Nov 22, 2019 · 5 comments · Fixed by #2486

Comments

@rawtaz
Copy link
Contributor

@rawtaz rawtaz commented Nov 22, 2019

When here are no pending changeling entries in the unreleased/ folder, the folder isn't tracked by git anymore. Add a .gitkeep file to the changelog/unreleased/ folder in order to make the folder always exist. This makes it less confusing for new contributors when the contributing instructions reference this folder.

@fd0

This comment has been minimized.

Copy link
Member

@fd0 fd0 commented Nov 23, 2019

Ah, we need to take care when we move the directory for a new release so that we don't accidentally remove the file. I think it'd be best to add the changelog workflow to our helper program.

@rawtaz

This comment has been minimized.

Copy link
Contributor Author

@rawtaz rawtaz commented Nov 23, 2019

I see, you move the unreleased dir to a new name and location. Makes sense.

Yeah we should probably make calens only move the files in this folder instead of the entire folder.

Regardless this file in the PR should be kept, don't you think? For an empty folder we need it there.

@fd0

This comment has been minimized.

Copy link
Member

@fd0 fd0 commented Nov 23, 2019

Yep, keep it. I'll fix calens.

@rawtaz rawtaz closed this in #2486 Nov 24, 2019
@rawtaz

This comment has been minimized.

Copy link
Contributor Author

@rawtaz rawtaz commented Nov 24, 2019

Really peculiar thing to happen :D For those interested in a more elaborate analysis, please see this thread in the forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.