New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/design: fix keys.data MAC format description #1189

Merged
merged 1 commit into from Aug 29, 2017

Conversation

Projects
None yet
3 participants
@FiloSottile
Contributor

FiloSottile commented Aug 28, 2017

"not including the last 32 byte" was wrong, should have been 16 bytes. But the whole description is redundant anyway.

doc/design: fix keys.data MAC format description
"not including the last 32 byte" was wrong, should have been 16 bytes. But the whole description is redundant anyway.
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 28, 2017

Codecov Report

Merging #1189 into master will decrease coverage by 5.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
- Coverage   52.93%   47.15%   -5.78%     
==========================================
  Files         126      126              
  Lines       12059    12059              
==========================================
- Hits         6384     5687     -697     
- Misses       4930     5682     +752     
+ Partials      745      690      -55
Impacted Files Coverage Δ
internal/backend/b2/b2.go 0% <0%> (-79.32%) ⬇️
internal/backend/swift/swift.go 0% <0%> (-73.9%) ⬇️
internal/backend/azure/azure.go 0% <0%> (-61.93%) ⬇️
internal/backend/gs/gs.go 0% <0%> (-59.85%) ⬇️
internal/backend/swift/config.go 34.37% <0%> (-56.25%) ⬇️
internal/archiver/archiver.go 64.79% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e96a3...3dccca1. Read the comment docs.

codecov-io commented Aug 28, 2017

Codecov Report

Merging #1189 into master will decrease coverage by 5.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
- Coverage   52.93%   47.15%   -5.78%     
==========================================
  Files         126      126              
  Lines       12059    12059              
==========================================
- Hits         6384     5687     -697     
- Misses       4930     5682     +752     
+ Partials      745      690      -55
Impacted Files Coverage Δ
internal/backend/b2/b2.go 0% <0%> (-79.32%) ⬇️
internal/backend/swift/swift.go 0% <0%> (-73.9%) ⬇️
internal/backend/azure/azure.go 0% <0%> (-61.93%) ⬇️
internal/backend/gs/gs.go 0% <0%> (-59.85%) ⬇️
internal/backend/swift/config.go 34.37% <0%> (-56.25%) ⬇️
internal/archiver/archiver.go 64.79% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e96a3...3dccca1. Read the comment docs.

@fd0

fd0 approved these changes Aug 29, 2017

@fd0 fd0 merged commit 3dccca1 into restic:master Aug 29, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

fd0 added a commit that referenced this pull request Aug 29, 2017

Merge pull request #1189 from FiloSottile/patch-2
doc/design: fix keys.data MAC format description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment