Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Skip archiver.Scan before backup when --quiet is set #1676
What is the purpose of this change? What does it change?
This PR ensures the backup command skips the
The reason behind the change is because the scan result is only used for displaying the progress bar and ETA estimation, but the scan result is not used when the quiet flag is set.
By skipping the scan before backup, the backup speed improves on large directory trees, especially when the entire directory tree cannot entirely fit into page cache, in which case the directory tree was twice read from the disk before this change is made.
Was the change discussed in an issue or in the forum before?
See issue #1160
I don't think this PR completely closes the above issue. This is only a quick change to improve the backup performance in some use cases with a minimal change in the code and logic.
@@ Coverage Diff @@ ## master #1676 +/- ## ========================================== - Coverage 51.6% 47.14% -4.46% ========================================== Files 143 143 Lines 11392 11394 +2 ========================================== - Hits 5879 5372 -507 - Misses 4606 5154 +548 + Partials 907 868 -39