Join GitHub today
WIP cmd_restore: expose filerestorer options in flags #2178
What is the purpose of this change? What does it change?
Expose internal tunnng options of the filerestorer on the restore command flags:
Was the change discussed in an issue or in the forum before?
Thanks for your contribution. Unfortunately it looks like you did not discuss this change in an issue before submitting it, or did I miss anything?
I'm not a fan of exposing internal values (which are internal for a reason: they can change without notice...) to users as flags. If we need to expose something, it must be a value that is clearly understandable. The values here are specific to the current restorer implementation, but once we change that for something else, the flags make no sense any more. In my opinion, exposing them it's not the right thing to do.
In general, the project's philosophy is to have a minimal user interface which works for most of the cases. Since we cannot just remove options from restic (because that'd break user scripts), we need to be very careful with what we decide to make configurable.
Users who want to experiment with the code can change the values in the code (after reading and understanding it, of course).
I'm against merging this PR, sorry about that.
referenced this pull request
Feb 22, 2019
thanks for your comments, I understand your point of view. Would it make more sense to expose these flags as extended options
You did not miss it, I missed it. I have created this issue: #2182
There are many related restore performance issues that may be overcome with the tuning of these options:
For the time being we will run our forked version with different tuning parameters against our petabyte-size storage repository to understand the performance fluctuations and we will provide you our analyses. If the performance increase is very significant it will be a pity that other restic users cannot benefit from all the power of this tool.
I am not in favour of this change, to be honest.