Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: Handle absolute pathname for --stdin-filename #2206

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@garrmcnu
Copy link
Contributor

garrmcnu commented Mar 11, 2019

What is the purpose of this change? What does it change?

Return valid directory info from Lstat() for parent directories of the specified filename. Previously only "/" and "." were valid directories.
Also set directory mode as this is checked by archiver.

Was the change discussed in an issue or in the forum before?

Closes #2063

Checklist

  • I have read the Contribution Guidelines
  • I have added tests for all changes in this PR
  • I have added documentation for the changes (in the manual)
  • There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
  • I have run gofmt on the code in all commits
  • All commit messages are formatted in the same style as the other commits in the repo
  • I'm done, this Pull Request is ready for review

garrmcnu added some commits Mar 11, 2019

fs: Handle absolute pathname for --stdin-filename
Return valid directory info from Lstat() for parent directories of the
specified filename. Previously only "/" and "." were valid directories.

Also set directory mode as this is checked by archiver.

Closes #2063
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #2206 into master will decrease coverage by 4.33%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2206      +/-   ##
==========================================
- Coverage   50.76%   46.42%   -4.34%     
==========================================
  Files         176      176              
  Lines       14251    14260       +9     
==========================================
- Hits         7234     6620     -614     
- Misses       5964     6652     +688     
+ Partials     1053      988      -65
Impacted Files Coverage Δ
internal/fs/fs_reader.go 68.46% <100%> (+4.82%) ⬆️
internal/backend/b2/b2.go 0% <0%> (-80.69%) ⬇️
internal/backend/swift/swift.go 0% <0%> (-78.45%) ⬇️
internal/backend/gs/gs.go 0% <0%> (-74%) ⬇️
internal/backend/azure/azure.go 0% <0%> (-69.46%) ⬇️
internal/backend/swift/config.go 36.95% <0%> (-54.35%) ⬇️
cmd/restic/cmd_mount.go 13.75% <0%> (-42.5%) ⬇️
internal/archiver/file_saver.go 84.21% <0%> (-4.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8d1dc...80ff133. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.