Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Examine file ctime when checking if files have changed. #2212
What is the purpose of this change? What does it change?
This makes restic compare file ctimes (in addition to all of the existing checks) when it is deciding if a file has been modified.
Was the change discussed in an issue or in the forum before?
Yes, closes #2179.
fd0 left a comment •
Thanks for taking a stab at this! This is a change which may leave users wondering what's happening, so we need to be extra careful to address this in the changelog. As far as I understood, there are some situations in which restic did not read the contents of the file, but does now (file with different content, but same length and
In my opinion, being correct and re-reading the contents if in doubt is the better strategy, so I'm in favor for this. Maybe we should add a paragraph to the changelog that people should open an issue if this breaks anything for them, so we can decide if we need a flag for it?
We need to clarify the following things before it can be merged:
@@ Coverage Diff @@ ## master #2212 +/- ## ========================================== - Coverage 50.92% 46.86% -4.06% ========================================== Files 178 178 Lines 14530 14534 +4 ========================================== - Hits 7399 6812 -587 - Misses 6058 6700 +642 + Partials 1073 1022 -51