Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examine file ctime when checking if files have changed. #2212

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@cbane
Copy link

cbane commented Mar 20, 2019

What is the purpose of this change? What does it change?

This makes restic compare file ctimes (in addition to all of the existing checks) when it is deciding if a file has been modified.

Was the change discussed in an issue or in the forum before?

Yes, issue #2179.

Checklist

  • I have read the Contribution Guidelines
  • I have added tests for all changes in this PR
  • I have added documentation for the changes (in the manual)
  • There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
  • I have run gofmt on the code in all commits
  • All commit messages are formatted in the same style as the other commits in the repo
  • I'm done, this Pull Request is ready for review
@cbane

This comment has been minimized.

Copy link
Author

cbane commented Mar 20, 2019

It looks like this change is breaking #2205 (or at least its unit tests). How do we want these to interact? The only idea I've had so far is disabling the ctime check if the ignore inode flag is on, but I'm open to anything that makes sense.

@d3zd3z

This comment has been minimized.

Copy link
Contributor

d3zd3z commented Apr 19, 2019

The only idea I've had so far is disabling the ctime check if the ignore inode flag is on, but I'm open to anything that makes sense.

The ctime value really only makes sense on the exact same inode, so this seems to me like a reasonable way of handling this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.